Dear Nils,

thanks for preparing the corresponding issue on GitHub. 

Let me just comment on your words "searching the source, this routine isn't 
actually used elsewhere in sage" (here: 
https://github.com/sagemath/sage/pull/37657). It is not entirely true, 
because, as far as I know, the method is_padic_square (in the class of a 
number field element) internally relies on the quadratic_defect.

BTW, it puzzles me why quadratic_defect is a method of a number field and 
is_padic_quare of its element. But it is a different story.

Thanks,
P.K.



On Saturday, March 23, 2024 at 4:55:50 PM UTC Nils Bruin wrote:

> Thanks! this is now 
>
> https://github.com/sagemath/sage/issues/37656
>
> or
>
> https://github.com/sagemath/sage/pull/37657
>
> (I'm still a bit murky on what issues are used for)
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/f5d042b2-731b-4c4c-8ca1-fc47b6bb4470n%40googlegroups.com.

Reply via email to