On 18 February 2024 15:51:27 GMT, Nathan Dunfield <nat...@dunfield.info> wrote:
>On Sunday, February 18, 2024 at 6:26:28 AM UTC-6 Dima Pasechnik wrote:
>
>I cannot imagine CI breaking down by, say, pytest.
>
>
>I can definitely see that happening, and indeed it seems to have done so
>for other projects:
>
>https://github.com/pytest-dev/pytest/issues/9765
>https://github.com/pytest-dev/pytest/issues/11983
>
Well, yes, a major pytest version jump might be an issue. We know this well, so
what?
>
>Besides, you can pin down or limit the version of a pip package, just as
>well. E.g. pin down the version of Cython. But leave its dependencies out
>of Sage, as much as possible.
>
>
>Leaving out dependencies doesn't eliminate complexity, it just hides it.
Why would two dependencies of pytest* and pytest* only need to enter Sage
codebase? No, there is no point in it, to the contrary it is more make-work,
more resources, longer build times, etc.
>That doesn't seem like an improvement to me.
well:
1) you can even just get a binary wheel of pytest installed - it is very fast,
and robust. Just like you do with pytest being optional. There is no need for
any extra deps getting in.
2) The major improvement is that sagelib will be easier to install into an
existing venv, and that's a wish of quite a number of users. Much more
Pythonic, too.
> Plus, some packages are
>dependencies of multiple other packages, and pip's ability to find a
>version of said dependency that all other packages will tolerate is not the
>greatest in my experience.
with Sage unnecessary pinning down a lot of package versions (and simply
vendoring them,) you cannot expect pip to do too well. We just have to let go
of many dependencies which are, needlessly, part of Sage, then pip will be able
to do the job well.
Dima
>
>Best,
>
>Nathan
>
>
>
--
You received this message because you are subscribed to the Google Groups
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/sage-devel/9B2C761F-C865-4332-8106-6EA364A89FBD%40gmail.com.
