I agree that we need a policy for disputed PRs. Such a policy should not operate in a way to condemn those raising objections to the PR since we want to keep kind, productive, caring atmosphere as Matthias put it. The policy should be clear and operate semi-automatically. So I suggest the following detail:
(1) When a PR becomes a disputed PR? A PR becomes a disputed PR when one reviewer adds "positive review" label, another reviewer removes it, and the author does not plan to work more on the PR according to the reviewer objections. (2) How do we count approvers and disapprovers for a disputed PR: A reviewer becomes an approver (who is in favor of the PR) when he/she sets "Approve" in the github review system. A reviewer becomes a disapprover (who objects the PR) when he/she sets "Request changes" in the github review system. Kwankyu -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/b2acbda8-c0bc-4fe6-b9d4-a6ee719951aan%40googlegroups.com.
