The branch protection rules don't allow to make an exception for a single 
person (the release manager). What can be configured though is that all 
pushes to develop (from everybody, including admins) have to go through a 
PR. This would mean that the merge and release commits also has to go 
through a PR. Maybe this is a good idea anyway, since then the github ci 
checks that everything is okay (relative to the setup tests) and would 
prevent the need for these "fix the ci" commits.

On Monday, 27 February 2023 at 05:54:29 UTC+8 Matthias Koeppe wrote:

> Branch protection is on, but currently admins can bypass it. This can be 
> tightened in the config here if so desired:
> https://github.com/sagemath/sage/settings/branch_protection_rules/33965567
>
>
> On Sunday, February 26, 2023 at 12:36:42 PM UTC-8 Volker Braun wrote:
>
>> I agree that we should turn on branch protection, it is rather easy to 
>> accidentally push to develop.
>>
>> Its also not ok to push what you think is a CI fix without it going to 
>> review, we had some irregularities to support the github transition but 
>> that is over now. 
>>
>>
>>
>> On Sunday, February 26, 2023 at 11:19:24 AM UTC+1 Vincent Delecroix wrote:
>>
>>> I do not understand why develop isn't protected against anybody but 
>>> the release manager pushes. 
>>>
>>> On Sun, 26 Feb 2023 at 11:16, Dima Pasechnik <[email protected]> wrote: 
>>> > 
>>> > it was a mistake on my side - I thought develop branch was broken, but 
>>> it was not. 
>>> > 
>>> > On Sun, 26 Feb 2023, 10:13 Vincent Delecroix, <[email protected]> 
>>> wrote: 
>>> >> 
>>> >> Hello, 
>>> >> 
>>> >> Why do we have commits on top of develop after the release commits? 
>>> Namely 
>>> >> 
>>> >> commit 52a81cbd161ef4d5895325657c88a68590ea1d3b 
>>> >> Author: Dima Pasechnik <[email protected]> 
>>> >> Date: Fri Feb 24 21:15:42 2023 +0000 
>>> >> 
>>> >> Revert "add missing # optional - gap3" 
>>> >> 
>>> >> This reverts commit c017a6a3d68f0aca8cb63ceba52fe451a64881a3. 
>>> >> 
>>> >> commit c017a6a3d68f0aca8cb63ceba52fe451a64881a3 
>>> >> Author: Dima Pasechnik <[email protected]> 
>>> >> Date: Fri Feb 24 11:57:32 2023 +0000 
>>> >> 
>>> >> add missing # optional - gap3 
>>> >> 
>>> >> to let CI pass 
>>> >> 
>>> >> Best 
>>> >> Vincent 
>>> >> 
>>> >> -- 
>>> >> You received this message because you are subscribed to the Google 
>>> Groups "sage-devel" group. 
>>> >> To unsubscribe from this group and stop receiving emails from it, 
>>> send an email to [email protected]. 
>>> >> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/sage-devel/CAGEwAAkF50jNxVth6io%2BCErWu9mWFW4L2D%2BERqQVcNf7aPjp1A%40mail.gmail.com.
>>>  
>>>
>>> > 
>>> > -- 
>>> > You received this message because you are subscribed to the Google 
>>> Groups "sage-devel" group. 
>>> > To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to [email protected]. 
>>> > To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/sage-devel/CAAWYfq0XTpPcxuKuE11ChKpx0jcAjsxGRVsrD%2BLDeQO-X4RxnQ%40mail.gmail.com.
>>>  
>>>
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/1796d13d-3abe-4bb3-a7b6-fd35fac65810n%40googlegroups.com.

Reply via email to