I agree that we should turn on branch protection, it is rather easy to accidentally push to develop.
Its also not ok to push what you think is a CI fix without it going to review, we had some irregularities to support the github transition but that is over now. On Sunday, February 26, 2023 at 11:19:24 AM UTC+1 Vincent Delecroix wrote: > I do not understand why develop isn't protected against anybody but > the release manager pushes. > > On Sun, 26 Feb 2023 at 11:16, Dima Pasechnik <dim...@gmail.com> wrote: > > > > it was a mistake on my side - I thought develop branch was broken, but > it was not. > > > > On Sun, 26 Feb 2023, 10:13 Vincent Delecroix, <20100.d...@gmail.com> > wrote: > >> > >> Hello, > >> > >> Why do we have commits on top of develop after the release commits? > Namely > >> > >> commit 52a81cbd161ef4d5895325657c88a68590ea1d3b > >> Author: Dima Pasechnik <di...@pasechnik.info> > >> Date: Fri Feb 24 21:15:42 2023 +0000 > >> > >> Revert "add missing # optional - gap3" > >> > >> This reverts commit c017a6a3d68f0aca8cb63ceba52fe451a64881a3. > >> > >> commit c017a6a3d68f0aca8cb63ceba52fe451a64881a3 > >> Author: Dima Pasechnik <di...@pasechnik.info> > >> Date: Fri Feb 24 11:57:32 2023 +0000 > >> > >> add missing # optional - gap3 > >> > >> to let CI pass > >> > >> Best > >> Vincent > >> > >> -- > >> You received this message because you are subscribed to the Google > Groups "sage-devel" group. > >> To unsubscribe from this group and stop receiving emails from it, send > an email to sage-devel+...@googlegroups.com. > >> To view this discussion on the web visit > https://groups.google.com/d/msgid/sage-devel/CAGEwAAkF50jNxVth6io%2BCErWu9mWFW4L2D%2BERqQVcNf7aPjp1A%40mail.gmail.com > . > > > > -- > > You received this message because you are subscribed to the Google > Groups "sage-devel" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to sage-devel+...@googlegroups.com. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/sage-devel/CAAWYfq0XTpPcxuKuE11ChKpx0jcAjsxGRVsrD%2BLDeQO-X4RxnQ%40mail.gmail.com > . > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/3e520e29-93ba-4220-8b0d-3ba647792e73n%40googlegroups.com.
