I followed your instructions but I got this message when pushing: $ git push trac HEAD Enumerating objects: 13, done. Counting objects: 100% (13/13), done. Delta compression using up to 4 threads Compressing objects: 100% (7/7), done. Writing objects: 100% (7/7), 661 bytes | 50.00 KiB/s, done. Total 7 (delta 6), reused 0 (delta 0), pack-reused 0 remote: FATAL: W refs/heads/u/gh_Eloitor/QuaternionOrder_fix sage gh-Eloitor DENIED by fallthru remote: error: hook declined to update refs/heads/u/gh_Eloitor/QuaternionOrder_fix To trac.sagemath.org:sage.git ! [remote rejected] HEAD -> u/gh_Eloitor/QuaternionOrder_fix (hook declined) error: failed to push some refs to 'trac.sagemath.org:sage.git'
Eloi On Friday, October 21, 2022 at 1:51:55 PM UTC+2 dim...@gmail.com wrote: > On Fri, Oct 21, 2022 at 11:29 AM Eloi Torrents <eloi.to...@gmail.com> > wrote: > > > > When constructing a quaternion order over a number field I get this > error: > > > > from sage.algebras.quatalg.quaternion_algebra import QuaternionOrder > > F.<w> = NumberField(x**2-x-1) > > A.<i,j,k> = QuaternionAlgebra(F, -1, -1) > > > > QuaternionOrder(A, [1, 3*i, 1/2*w + 1/2 + (3/2*w + 1)*i + 1/2*j, 1/2*w + > (3/2*w - 1/2)*i + 1/2*k]) > > > > https://pastebin.com/rCi9TsbU > > > > And this is the fix needed, but I don't know how should I contribute it: > https://github.com/sagemath/sage/compare/develop...Eloitor:sage:develop > > > > I tried to find a ticket about this but didn't find anything. Should I > open one? > > yes, open a ticket (logging in with your github login), then put up > your branch for review there. > > Specifically, add remote to your git repo: > > $ git remote add trac g...@trac.sagemath.org:sage.git > > make sure your branch has correct name - it should start with > "u/gh_Eloitor/", e.g. > > $ git checkout -b u/gh_Eloitor/QuaternionOrder_fix > > and push it it to trac: > > $ git push trac HEAD > > (make sure your branch is based on the latest beta, currently 9.8.beta2) > > On the ticket, enter u/gh_Eloitor/QuaternionOrder_fix into "branch" tab > > HTH > Dima > > > > > > > > Eloi > > > > -- > > You received this message because you are subscribed to the Google > Groups "sage-devel" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to sage-devel+...@googlegroups.com. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/sage-devel/5e069544-f8cb-43b8-9bf4-6ed57e06a9acn%40googlegroups.com > . > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/ba73916e-211d-4a12-908e-192617a7b1f6n%40googlegroups.com.