On Fri, Oct 21, 2022 at 11:29 AM Eloi Torrents <eloi.torren...@gmail.com> wrote:
>
> When constructing a quaternion order over a number field I get this error:
>
> from sage.algebras.quatalg.quaternion_algebra import QuaternionOrder
> F.<w> = NumberField(x**2-x-1)
> A.<i,j,k> = QuaternionAlgebra(F, -1, -1)
>
> QuaternionOrder(A, [1, 3*i, 1/2*w + 1/2 + (3/2*w + 1)*i + 1/2*j, 1/2*w +
> (3/2*w - 1/2)*i + 1/2*k])
>
> https://pastebin.com/rCi9TsbU
>
> And this is the fix needed, but I don't know how should I contribute it:
> https://github.com/sagemath/sage/compare/develop...Eloitor:sage:develop
>
> I tried to find a ticket about this but didn't find anything. Should I open
> one?
yes, open a ticket (logging in with your github login), then put up
your branch for review there.
Specifically, add remote to your git repo:
$ git remote add trac g...@trac.sagemath.org:sage.git
make sure your branch has correct name - it should start with
"u/gh_Eloitor/", e.g.
$ git checkout -b u/gh_Eloitor/QuaternionOrder_fix
and push it it to trac:
$ git push trac HEAD
(make sure your branch is based on the latest beta, currently 9.8.beta2)
On the ticket, enter u/gh_Eloitor/QuaternionOrder_fix into "branch" tab
HTH
Dima
>
> Eloi
>
> --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/5e069544-f8cb-43b8-9bf4-6ed57e06a9acn%40googlegroups.com.
--
You received this message because you are subscribed to the Google Groups
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/sage-devel/CAAWYfq3_N_9%2BF4z03%3Def0uW1-cBuGfe9zFW5LK7uFR9XNUuG9w%40mail.gmail.com.
