On Sat, Jun 4, 2022 at 3:01 AM Yingdong Li <lyd01022...@gmail.com> wrote: > > Dear all, > > Motivated by problems about modular forms, we want to find the ring structure > of Hecke algebra. Therefore, I have written some codes in Sage to compute the > finite-dimensional algebra by a list of commuting matrices and I want to > contribute it to Sage. Here is the idea of my codes. > > 1. We can construct the algebra as a quotient of a polynomial ring(by using > the homomorphism which sends each x_i to t_i, where t_1,...,t_n is the n > matrices generate the algebra), we can also get the basis by doing this. > > 2. With the basis of the algebra, we can also compute the multiplication > table then use the finite-dimensional algebra command in Sage to get a > description to this algebra. > > Once we have done with these things above, we can get the ring structure of > the algebra. This is very useful in dealing with some problems about modular > forms since we can further study the prime ideals or maximal ideals of Hecke > algebra by using its ring structure. > > I'm an undergraduate student and this is part of my research project and I > want to contribute my code to Sage. I have put my code on my GitHub page so > that you can clearly see the code. If you have some questions or comments on > this(or you find some bugs in this code), we can discuss about it here. >
It would be helpful if you reformat your code so the style is consistent with PEP 8, which is the standard for writing Python code: https://peps.python.org/pep-0008/ E.g., function names should start with lower case letters, etc. The code on line 130 that starts: " def MakeMultiplicationTable(L): #Input: A basis L of a finite dimensional algebra #Output: A multiplication table M=[] " looks possibly mangled, since it looks to be indented incorrectly. Also, you might want to include some examples in your docstrings that show working examples of using your code, which anybody can copy/paste into a Sage session, so they can try it out. > Here's a link of my code in GiHub(see the code called "Finite generated > algebra as a ring") > Dongulas/Dongulas: Config files for my GitHub profile. > > (I have posted a similar discussion on Sage-devel before, but I think it's > better to add the link of my code here to make the idea more clear.) > > Thanks in advance! > > > Best wishes, > Li Yingdong > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sage-devel/ba198d06-ab76-48eb-a740-637347e0942cn%40googlegroups.com. -- William (http://wstein.org) -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CACLE5GDkfdiRA2wBcqV2CAmACQdT89SQ94z%3DDtmQvfF-jBLkoQ%40mail.gmail.com.
