Hi, > Please open a ticket for it. Thank you for the encouragement but this hitchhiker has admitted her weakness with the ticket system. It is just a copy and paste snippet, maybe those who are in charge of ' configure.ac' could help with the ticket issue?
All the best, phiho On Fri, May 27, 2022 at 2:43 PM Matthias Koeppe <matthiaskoe...@gmail.com> wrote: > Yes, such checks in "configure.ac" would be a good idea. Please open a > ticket for it. > > On Friday, May 27, 2022 at 4:33:14 AM UTC-7 hohoa...@gmail.com wrote: > >> Hi, >> >> Maybe the tests with "contains_spaces()" in 'src/bin/sage-env' can be >> replaced with the followings in 'configure.ac' (after line 75, >> SAGE_LOCAL="$prefix"): >> >> *<configure.ac <http://configure.ac>>* >> # Check that we are not building in a directory containing spaces >> AS_IF([echo "$ac_pwd" |grep " " >/dev/null], >> AC_MSG_ERROR([The path to the Sage root directory ($ac_pwd) >> contains a space. Sage will not build correctly in this case]) >> ) >> >> # Check that we are not installing to a directory containing spaces >> AS_IF([echo "$SAGE_LOCAL" |grep " " >/dev/null], >> AC_MSG_ERROR([The path to the Sage installation directory >> ($SAGE_LOCAL) contains a space. Sage will not work correctly in this case]) >> ) >> *</configure.ac <http://configure.ac>>* >> >> The first AS_IF() was moved up from below (around line 420) >> >> Thank you for your help. >> >> Regards, >> >> phiho >> >> >> On Tue, May 24, 2022 at 7:32 PM Matthias Koeppe <matthia...@gmail.com> >> wrote: >> >>> On Tuesday, May 24, 2022 at 3:11:00 PM UTC-7 hohoa...@gmail.com wrote: >>> >>>> Does this apply only to "$SAGE_ROOT"? >>>> Can sub-directories of "$SAGE_ROOT" (like "lo space cal") contain >>>> spaces? >>>> Is it OK for $SAGE_LOCAL to contain spaces? If it is so, why the >>>> differences? >>>> >>> >>> We do not systematically test this, but also SAGE_LOCAL should not >>> contain spaces. >>> >>> Many of our build scripts do not quote correctly and will break when >>> SAGE_LOCAL contains spaces. >>> For example, look at >>> https://github.com/sagemath/sage/blob/develop/build/pkgs/fplll/spkg-install.in >>> : >>> If SAGE_LOCAL is "/lo space cal", then when >>> CONFIGURE_FLAGS="--prefix=$SAGE_LOCAL --libdir=$SAGE_LOCAL/lib" is passed >>> to sdh_configure, it will expand to too many arguments. >>> >>> Fixing this would be a welcome contribution -- but likely also many >>> upstream projects have the same issues in their build scripts. >>> >>> >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "sage-devel" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to sage-devel+...@googlegroups.com. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/sage-devel/bf505cca-95bc-4fe9-8aa7-4cfa736da55bn%40googlegroups.com >>> <https://groups.google.com/d/msgid/sage-devel/bf505cca-95bc-4fe9-8aa7-4cfa736da55bn%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sage-devel/4f01c6f9-9c33-4b4f-b431-58ae052efbe4n%40googlegroups.com > <https://groups.google.com/d/msgid/sage-devel/4f01c6f9-9c33-4b4f-b431-58ae052efbe4n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CALZQg1a8-OxAGWeWDoDpip%3DpdqTkjE4DfS%3DTooq%2B8%3DV00kLrWQ%40mail.gmail.com.
