The check during "bootstrap" would not help because the files that bootstrap generates go into a source distribution.
On Friday, May 27, 2022 at 5:28:53 AM UTC-7 hohoa...@gmail.com wrote: > P.S: Would this snippet in 'bootstrap' (below SAGE_ROOT=...) help, too: > > # Set SAGE_ROOT to the path to this file and then cd into it > SAGE_ROOT="$(cd "$(dirname "$0")" && pwd -P)" > > > # Check that we are not building in a directory containing spaces > if echo "$SAGE_ROOT" | grep " " > /dev/null ; then > echo "The path to the Sage root directory ($SAGE_ROOT) contains a > space. Sage will not build correctly in this case." > exit 1 > fi > > > > > On Fri, May 27, 2022 at 7:33 AM ph h <hohoa...@gmail.com> wrote: > >> Hi, >> >> Maybe the tests with "contains_spaces()" in 'src/bin/sage-env' can be >> replaced with the followings in 'configure.ac' (after line 75, >> SAGE_LOCAL="$prefix"): >> >> *<configure.ac <http://configure.ac>>* >> # Check that we are not building in a directory containing spaces >> AS_IF([echo "$ac_pwd" |grep " " >/dev/null], >> AC_MSG_ERROR([The path to the Sage root directory ($ac_pwd) >> contains a space. Sage will not build correctly in this case]) >> ) >> >> # Check that we are not installing to a directory containing spaces >> AS_IF([echo "$SAGE_LOCAL" |grep " " >/dev/null], >> AC_MSG_ERROR([The path to the Sage installation directory >> ($SAGE_LOCAL) contains a space. Sage will not work correctly in this case]) >> ) >> *</configure.ac <http://configure.ac>>* >> >> The first AS_IF() was moved up from below (around line 420) >> >> Thank you for your help. >> >> Regards, >> >> phiho >> >> >> >> On Tue, May 24, 2022 at 7:32 PM Matthias Koeppe <matthia...@gmail.com> >> wrote: >> >>> On Tuesday, May 24, 2022 at 3:11:00 PM UTC-7 hohoa...@gmail.com wrote: >>> >>>> Does this apply only to "$SAGE_ROOT"? >>>> Can sub-directories of "$SAGE_ROOT" (like "lo space cal") contain >>>> spaces? >>>> Is it OK for $SAGE_LOCAL to contain spaces? If it is so, why the >>>> differences? >>>> >>> >>> We do not systematically test this, but also SAGE_LOCAL should not >>> contain spaces. >>> >>> Many of our build scripts do not quote correctly and will break when >>> SAGE_LOCAL contains spaces. >>> For example, look at >>> https://github.com/sagemath/sage/blob/develop/build/pkgs/fplll/spkg-install.in >>> : >>> If SAGE_LOCAL is "/lo space cal", then when >>> CONFIGURE_FLAGS="--prefix=$SAGE_LOCAL --libdir=$SAGE_LOCAL/lib" is passed >>> to sdh_configure, it will expand to too many arguments. >>> >>> Fixing this would be a welcome contribution -- but likely also many >>> upstream projects have the same issues in their build scripts. >>> >>> >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "sage-devel" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to sage-devel+...@googlegroups.com. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/sage-devel/bf505cca-95bc-4fe9-8aa7-4cfa736da55bn%40googlegroups.com >>> >>> <https://groups.google.com/d/msgid/sage-devel/bf505cca-95bc-4fe9-8aa7-4cfa736da55bn%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/a2140bb3-6fdc-4eca-9c5a-05a48cf22c37n%40googlegroups.com.
