On Sun, Feb 24, 2008 at 12:26 PM, Simon King <[EMAIL PROTECTED]> wrote: > Dear William, > > my usual mail server doesn't work, so i'm using a different address. > > I tried to implement a tensor product for matrices. I did so in matrix2.pyx, > as you suggested. The code is almost trivial, the example is much longer. I > just test whether the second argument is of type Matrix; but i do not test > whether the rings of the two matrices fit -- because this is implicitly > tested when the matrix coefficients are dealt with. I hope this is safe > enough.
Yes, it should be. > Do i understand correctly that i shall open a new trac ticket, post my patch > there, and include the label "[with patch, needs review]" in the title of > the ticket? Yes, exactly right. > I understood that having a doc-test means to have the key word EXAMPLES in > the doc string, followed by input and output of the example. Is this > correct, or is there something else to do? Yes. And if anything is wrong it will get listed by the reviewer of your patch. > This is the first time that i try to submit code, so please excuse my > questions. No problem. Welcome to being a sage developer. One thing -- we prefer text patches these days if possible. To make one, do sage: hg_sage.log() to find the patchset number of your patch, then do sage: hg_sage.export(number) and you'll get a plain text file number.patch which you can look at and post to trac. -- William --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~----------~----~----~----~------~----~------~--~---
