Jaap Spies wrote: > Hi, > > From my IRC log: > > <mabshoff_> Not in detail. I downloaded the patch and looked at it a > little. > <mabshoff_> But it is obviously huge. > <jkantor> I was going to add stuff about the preparser at sd8 since > they seemed to want to know about it. > <mabshoff_> But since it increases coverage by 2% I am sure it will be > reviewed and merged :) > <wstein> 2%: sweet > <mabshoff_> How long does the doctest of that file run? > <mabshoff_> And don't you need net or an optional database to test it= > <mhansen> I think like 4 seconds. > <mabshoff_> ? > <mabshoff_> ok > <mhansen> Nope > <mabshoff_> ok, good to know. > <mabshoff_> That was a huge piece of work :) > <mhansen> It was so demotivating to have that sitting in combinat/ :) > <wstein> :-) > <wstein> Maybe Jaap Spies could referee it, since he wrote the code. > <mabshoff_> I didn't know that it sat in combinat. > <wstein> But he might be out sailing his yacht... > <mabshoff_> :) > > lol! No, I'm not out sailing, just a few days afk. > > But I'm not amused! Please look at the details! All sloane_functions > have extensive examples. But from design they are placed just after > the class declaration. It feels stupid to have "internal" functions > starting with '__' or '_' documented with EXAMPLES! > > Let us think at the effect on the reference manual. > I don't think it is a good idea to have internal functions like > __init, _repr and other "hidden" fuctions documented with examples > figuring in the Reference Manual. > > If we want users of the OEIS to use Sage, we have to provide them with > adequate examples. Maybe raising the doctest coverage with 2% looks good > but it isn't in this case. > > Adding some sloane-functions I was following the 'template'. So there > is, maybe, something wrong with the overall design. > > As it is I'll give trac-2275 a negative review. > > Jaap > >
This discussion should be on sage-devel. Cheers, Michael --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~----------~----~----~----~------~----~------~--~---
