On Sep 1, 7:13 pm, David Harvey <[EMAIL PROTECTED]> wrote:
> On Sep 1, 2007, at 1:08 PM, William Stein wrote:
>
>
>
>
>
> > On 9/1/07, David Harvey <[EMAIL PROTECTED]> wrote:
> >> On Sep 1, 2007, at 12:59 PM, Robert Bradshaw wrote:
> >>>> Suppose I attach a patch to a ticket, which I believe solves the
> >>>> issue. Do I close the ticket at that point myself? Or should the
> >>>> ticket only be closed by the person who puts the patch into the
> >>>> "main" repository?
>
> > For purely practical reasons, please don't close it until it's been
> > posted to the main repository. Otherwise, what will happen is
> > that I'll view that as done, and I won't ever actually post it to the
> > main repository! I'll never even see it as being on the list if
> > things
> > for me to do.
>
> > Second, it's not unlikely for somebody to *think* they've fixed
> > something,
> > but when other people look at what they've done they think otherwise.
> > Thus having somebody else close the ticket also makes sense from
> > that point
> > of view.
>
> In that case, what is the right way to "notify" that a patch has been
> attached? I guess what I'm saying is: how does the main repository
> maintainer know where to look for tickets that are probably ready to
> be closed? Is that managed by the "milestone" field? Is there some
> database query that picks these things up?
No, No and No. The only chance to catch an attached patch is to look
at it manually (bad, but we are getting better at it) or being in the
CC field. I think that we should create a sage-trac-ticket google
group and just CC any chances there per default. It is high traffic,
but for the few of us who want to watch the flow of tickets it migh
make things easier to deal with.
Coming into #sage-devel and announcing that a patch has been created
might be the best short term solution.
> I want to avoid a
> situation where people attach patches which sit on trac for months
> without being looked at.
Hopefully we go those applied & closed during the last two weeks. I
went through all the tickets and tagged everything with a patch as
2.8.x, so at least the older ones should all be gone. I check
periodically (mostly when I am bored/not motivated to do any "real"
work) and Mike Hansen has also been seen checking tickers, so with at
least 2 people paying attention it shouldn't be too bad. Bu having a
resolved status would really be nice to pretty much focus attention on
those issues.
>
> david
Cheers,
Michael
--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://sage.scipy.org/sage/ and http://modular.math.washington.edu/sage/
-~----------~----~----~----~------~----~------~--~---
