On 9/1/07, David Harvey <[EMAIL PROTECTED]> wrote: > On Sep 1, 2007, at 12:59 PM, Robert Bradshaw wrote: > >> Suppose I attach a patch to a ticket, which I believe solves the > >> issue. Do I close the ticket at that point myself? Or should the > >> ticket only be closed by the person who puts the patch into the > >> "main" repository?
For purely practical reasons, please don't close it until it's been posted to the main repository. Otherwise, what will happen is that I'll view that as done, and I won't ever actually post it to the main repository! I'll never even see it as being on the list if things for me to do. Second, it's not unlikely for somebody to *think* they've fixed something, but when other people look at what they've done they think otherwise. Thus having somebody else close the ticket also makes sense from that point of view. > > I think there should be a "resolved" state when a patch is created/ > > attached that solves the problem, and then finally closed when it > > makes it into the main repository (and doesn't cause other issues). > > I can't see how to make that distinction with the interface. > > The smallest change I can make is to "resolve as fixed", but that > closes the ticket (puts a strikeout through it). > > For example I just tried it with #550, which is now closed, although > presumably the patch hasn't been applied by anyone to the main > repository. Amusingly, I was applying your #550 to the main repository and trying to close it at the exact same moment that you closed it -- which locked me out from closing it :-) Anyway it is in the main repo now, so leave it closed. William --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://sage.scipy.org/sage/ and http://modular.math.washington.edu/sage/ -~----------~----~----~----~------~----~------~--~---
