Hello Frantisek!
And Matthias and William,
and i hope it's ok that i Cc: the S-nail list, too.
frantisek holop <[email protected]> wrote:
|hello
|
|i have forwarded your message to William,
|in the end he is the maintainer and it is
|his call if he wants to act on your comments.
It's around this time again..
|i just wanted to start the ball rolling :)
|have you seen the comments on ports@
|regarding the new version?
Thanks for pointing me to this thread!
And very special thanks to Matthias for using such an expensive
flag and reporting the bug!!
Indeed there are a one-line bug and a one-line oversight involved,
one introduced in February on a review topic branch (damn!!) and
one back in July once i've implemented (directly addressable)
readonly mailboxes (via the `File' command).
While there i detected that a readonly opened mailbox can loose
it's readonly bit via `newmail', so this is also fixed.
Please find the patch attached below, all those have been pushed
to the [master] branch already, too.
I cannot reproduce the reported impossible automatic `next'?
And i've already pointed out to Frantisek that using editline(3)
is definetely the worst choice for command line editing in S-nail,
and i couldn't make it properly support a coloured prompt on all
tested platforms and revisions. Support may even be removed.
I personally only use the NCL, and it supports the most features,
including marking out gabby history entries etc. -- readline(3)
can perform superior tab-expansion, however.
P.S.: no subminor release for that, at least not know. I have
absolutely no time for S-nail at the moment, and if there really
has to be another subminor then i want to perform at least
a review on the manual, the .rc file, do some stuff here and
there, and thoroughly review the mandatory-configuration-option
support that is on [next] for quite some time. Even more would be
even better.
Ciao,
--steffen
diff --git a/cmd3.c b/cmd3.c
index 4aba41f..99409c6 100644
--- a/cmd3.c
+++ b/cmd3.c
@@ -1324,7 +1324,9 @@ c_newmail(void *v)
#ifdef HAVE_IMAP
(mb.mb_type != MB_IMAP || imap_newmail(1)) &&
#endif
- (val = setfile(mailname, FEDIT_NEWMAIL)) == 0) {
+ (val = setfile(mailname,
+ FEDIT_NEWMAIL | ((mb.mb_perm & MB_DELE) ? FEDIT_RDONLY : 0))
+ ) == 0) {
mdot = getmdot(1);
setdot(message + mdot - 1);
}
diff --git a/lex.c b/lex.c
index be05ccc..c3e2652 100644
--- a/lex.c
+++ b/lex.c
@@ -692,7 +692,8 @@ commands(void)
size_t odot = PTR2SIZE(dot - message);
bool_t odid = did_print_dot;
- setfile(mailname, 1);
+ setfile(mailname,
+ FEDIT_NEWMAIL | ((mb.mb_perm & MB_DELE) ? FEDIT_RDONLY : 0));
if (mb.mb_type != MB_IMAP) {
dot = message + odot;
did_print_dot = odid;
diff --git a/maildir.c b/maildir.c
index 8e1b885..a16466e 100644
--- a/maildir.c
+++ b/maildir.c
@@ -622,7 +622,7 @@ mktable(void)
_maildir_prime = nextprime(msgCount);
_maildir_table = scalloc(_maildir_prime, sizeof *_maildir_table);
- for (mp = message, i = msgCount; i-- != 0;)
+ for (mp = message, i = msgCount; i-- != 0; ++mp)
mdlook(mp->m_maildir_file + 4, mp);
NYD_LEAVE;
}
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
S-nail-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/s-nail-users
