On 9-4-2016 9:40, Todd Wade wrote: > On 4/7/16 8:50 AM, Joop wrote: >> like an URL encoded block of text which is 8000 chars. >> Shouldn't PreviewScrips use POST instead of GET because of the possible >> large amount of text? > > Yeah it looks like that should POST. > > I put in a pull request for this: > > https://github.com/bestpractical/rt/pull/184 > https://github.com/bestpractical/rt/pull/184.diff > > I had to add a helper to util.js because unfortunately it looks like > theres no way to serialize the form as an object with stock jQuery. So > you might want to wait to see if BPS accepts this as-is before > applying it. > I implemented this patch and it works OK but has a unpleasant side effect. How to reproduce: Reply to a ticket and make sure you have the right to see the scrip preview pane Notice that all that need to recieve email are having a checkmark! Click into the message body reply field, type some text, not really needed Click outside the text field on a place that is NOT a other form element such as the Owner dropdown. Notice that the checkmarks disappear :-(
Will amend the PR with this info too. Joop --------- RT 4.4 and RTIR Training Sessions https://bestpractical.com/training * Washington DC - May 23 & 24, 2016
