-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Lapo Luchini wrote:
> This third attempt solves both the august security fix and the textmode
> bug that 2.6.2-2 had.
Whoops, I forgot to ask if the patch could be kindly included in the
original source (it follows). I don't think there is any reason not to
ask for "binary mode" on non-Windows hosts, anyway (it's already done
also in do_open(...), also).
> If you're using 2.6.2-1 or earlier version to avoid the textmode bug,
> you're now strongly advised to upgrade to 2.6.2-4
and by the way.. yes, this was a typo, no 2.6.2-4 version exists nor it
will ever be, it was meant to be "upgrade to 2.6.2-3" (next one will be
2.6.3-1).
Here comes the patch (with many thanks to Sjoerd Mullender for having
found the long standing bug, that insidiously began to show up only in
last version (I still wonder why it didn't show in earlier build, really)):
diff -urN -x .build -x .inst -x .sinst rsync-2.6.2-orig/syscall.c
rsync-2.6.2/syscall.c
- --- rsync-2.6.2-orig/syscall.c 2004-02-18 23:33:21.000000000 +0100
+++ rsync-2.6.2/syscall.c 2004-09-28 13:05:03.187353800 +0200
@@ -164,6 +164,7 @@
errno = errno_save;
return -1;
}
+ setmode(fd, O_BINARY);
return fd;
}
#else
- --
L a p o L u c h i n i
l a p o @ l a p o . i t
w w w . l a p o . i t /
http://www.megatokyo.it
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iEYEARECAAYFAkFciVsACgkQaJiCLMjyUvskHwCeMX+ftxMRRs8sm/DmfInN5K/s
Z5EAoN+a5cYMUloq56ZkvM4BVROBfpL4
=1TSX
-----END PGP SIGNATURE-----
--
To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
