@pmatilai commented on this pull request.
> @@ -1774,13 +1781,14 @@ static void pushMacroAny(rpmMacroContext mc,
}
static void pushMacro(rpmMacroContext mc,
- const char * n, const char * o, const char * b, int level, int flags)
+ const string & n, const char * o, const string & b,
It is, I noticed that too while doing this PR.
There's a *kind of* an inner logic in there: the functions that have a
prototype in the header are using std::string in both places, other places take
a the string shortcut. We should figure out a standard what to do with these
and stick with that, but there are just sooooooo many such decisions to make,
at a time when we're not really ready to make them :sweat_smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3477#discussion_r1863254164
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3477/review/2469522...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint
