@voxik commented on this pull request.


> @@ -1774,13 +1781,14 @@ static void pushMacroAny(rpmMacroContext mc,
 }
 
 static void pushMacro(rpmMacroContext mc,
-       const char * n, const char * o, const char * b, int level, int flags)
+               const string & n, const char * o, const string & b,

I might be missing something, but using `string` on some places while 
`std::string` on other places seems inconsistent to me.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3477#pullrequestreview-2469507022
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3477/review/2469507...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to