@dmnks commented on this pull request.
>
- if (!rc && replace) {
- /* find and delete the old pubkey entry */
- if (delete_key(txn, fp, keyfmt) == RPMRC_NOTFOUND) {
- /* make sure an old, short keyid version gets removed */
- delete_key(txn, fp+32, keyfmt);
- }
- }
+static void free_write_lock(int fd)
+{
+ flock(fd, LOCK_UN);
I'd say it's fine to keep the file around, whoever wants to access the keystore
is expected to use the file locking syscall anyway.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3437#discussion_r1837778285
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3437/review/2429068...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
