@pmatilai commented on this pull request.


>      rpmPubkey key = NULL;
+    std::vector<std::pair<int, std::string>> results = {};

And here too - the results vector is only needed inside the main if, so that's 
where it belongs. And key inside the only code that can actually end with it 
being set.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3398#pullrequestreview-2391460713
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3398/review/2391460...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to