@pmatilai commented on this pull request.
> free(lints);
}
- if (keyptr) {
- *keyptr = pubkeyPrimarykey(key);
+
+ for (auto const & item : results) {
+ if (((rc == RPMRC_OK) == (item.first == RPMRC_OK))
Just a side-remark as I think clearing the results on OK is a better solution
here, but such code can usually be made far more readable by giving the complex
condition a human understandable name. Eg this might be something like
```
bool relevant_result = ((rc == RPMRC_OK) == (item.first == RPMRC_OK));
if (relevant_result && !item.second.empty)
rpmlog()...
```
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3398#pullrequestreview-2391490191
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3398/review/2391490...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
