Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3712#discussion_r22013758
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateTableAsSelect.scala
---
@@ -44,11 +44,7 @@ case class CreateTableAsSelect(
tableName: String,
query: LogicalPlan,
allowExisting: Boolean,
- desc: Option[CreateTableDesc]) extends LeafNode with Command {
-
- def output = Seq.empty
-
- private[this] def sc = sqlContext.asInstanceOf[HiveContext]
+ desc: Option[CreateTableDesc])(@transient sc: HiveContext) extends
RunnableCommand {
--- End diff --
Its a little odd to have a var named `sc` that is not a `SparkContext`,
also I think we should try and eliminate this since we get the SQLContext in
the run method. Can we just move `metastoreRelation` into the run method?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
