Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3712#discussion_r22013440
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -306,13 +306,16 @@ private[sql] abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
def apply(plan: LogicalPlan): Seq[SparkPlan] = plan match {
case r: RunnableCommand => ExecutedCommand(r) :: Nil
--- End diff --
Okay, I see the problem now. These commands still live inside of catalyst
and thus cannot be `RunnableCommands`. I would argue that that should be
changed. My whole goal here was to eliminate boilerplate from the planner and
this still seems to have a bunch of it. That said, this could be done in a
follow up PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
