Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/3082#discussion_r19841156
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -124,6 +125,22 @@ private[spark] class ExecutorAllocationManager(sc:
SparkContext) extends Logging
throw new SparkException(s"spark.dynamicAllocation.minExecutors
($minNumExecutors) must " +
s"be less than or equal to spark.dynamicAllocation.maxExecutors
($maxNumExecutors)!")
}
+ if (schedulerBacklogTimeout <= 0) {
+ throw new
SparkException("spark.dynamicAllocation.schedulerBacklogTimeout must be > 0!")
+ }
+ if (sustainedSchedulerBacklogTimeout <= 0) {
+ throw new SparkException(
+ "spark.dynamicAllocation.sustainedSchedulerBacklogTimeout must be
> 0!")
+ }
+ if (executorIdleTimeout <= 0) {
+ throw new
SparkException("spark.dynamicAllocation.executorIdleTimeout must be > 0!")
+ }
+ // Require external shuffle service for dynamic allocation
--- End diff --
(Either way, doesn't need to hold up this JIRA. Given the current
implementation, disabling dynamic allocation when there's no external shuffle
service seems like the right thing to do.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
