Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10835#issuecomment-174356027
I took a fairly broad pass over this and the bulk of the changes here look
straightforward. Most of my comments above are fairly minor.
Let me take a closer look at the followup patch for SPARK-12896 in order to
try to better understand the comments and disabled tests which reference it.
One high-level question: as part of this migration of task metrics to
accumulators, I believe that we planned to introduce a mechanism to opt out of
accumulator update de-duplication logic for these internal metric accumulators.
Are you planning to do that change as part of these two patches or will that be
deferred to followup
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
