Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10835#discussion_r50645733
--- Diff: core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala
---
@@ -378,15 +374,20 @@ class JsonProtocolSuite extends SparkFunSuite {
val oldInfo = JsonProtocol.accumulableInfoFromJson(oldJson)
assert(false === oldInfo.internal)
}
+}
- /** -------------------------- *
- | Helper test running methods |
- * --------------------------- */
- private def testEvent(event: SparkListenerEvent, jsonString: String) {
+// This extends SparkFunSuite only because we want its `assert` method.
+private[spark] object JsonProtocolSuite extends SparkFunSuite {
--- End diff --
What's the motivation for moving these into a separate object? Are you
trying to reuse some of these methods in a different suite?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
