Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7888#discussion_r44839325
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -442,7 +452,7 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
numPendingExecutors += knownExecutors.size
}
- doKillExecutors(executorsToKill)
+ (force || !executorsToKill.isEmpty) && doKillExecutors(executorsToKill)
--- End diff --
Just `doKillExecutors` wouldn't work; this needs to return `false` when
executors are not killed, otherwise the code to cleanup
`executorsPendingToRemove` in `ExecutorAllocationManager` would be needed.
But the return can be simplified:
executorsToKill.nonEmpty && doKillExecutors(executorsToKill)
The list can only be empty when `force` is `false` (or an empty list was
provided in the first place), so checking `force` is redundant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
