Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7888#discussion_r44812769
--- Diff:
core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala
---
@@ -455,6 +482,19 @@ class StandaloneDynamicAllocationSuite
sc.killExecutors(getExecutorIds(sc).take(n))
}
+ private def killExecutorWithForce(
+ sc: SparkContext,
+ executorId: String,
+ force: Boolean = true): Boolean = {
--- End diff --
I would just call this `killExecutor` since `force` can be false. Also to
make things clearer I wouldn't make this take in a default value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
