dongjoon-hyun commented on code in PR #514:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/514#discussion_r2891363077
##########
spark-operator-api/src/main/java/org/apache/spark/k8s/operator/status/BaseAttemptSummary.java:
##########
@@ -33,6 +33,6 @@
@RequiredArgsConstructor
@JsonInclude(JsonInclude.Include.NON_NULL)
@JsonIgnoreProperties(ignoreUnknown = true)
-public class BaseAttemptSummary {
- protected final AttemptInfo attemptInfo;
+public class BaseAttemptSummary<AI extends BaseAttemptInfo> {
+ protected final AI attemptInfo;
Review Comment:
Oh, `AI` looks like a bad naming. Please choose something else, @jiangzho .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
