dongjoon-hyun commented on code in PR #514: URL: https://github.com/apache/spark-kubernetes-operator/pull/514#discussion_r2891356993
########## spark-operator-api/src/main/java/org/apache/spark/k8s/operator/status/ApplicationAttemptInfo.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.spark.k8s.operator.status; + +import com.fasterxml.jackson.annotation.JsonIgnoreProperties; +import com.fasterxml.jackson.annotation.JsonInclude; +import lombok.EqualsAndHashCode; +import lombok.Getter; +import lombok.Setter; +import lombok.ToString; + +/** + * Information about an attempt. + * + * <p>Maintains counters for different restart limit checks: + * <ul> + * <li><b>failureRestartCounter</b>: Consecutive failure count, checked against + * maxRestartOnFailure</li> + * <li><b>schedulingFailureRestartCounter</b>: Consecutive scheduling failure count, checked + * against maxRestartOnSchedulingFailure</li> + * </ul> + * + */ +@Setter +@Getter +@EqualsAndHashCode(callSuper = true) +@ToString(callSuper = true) +@JsonInclude(JsonInclude.Include.NON_NULL) +@JsonIgnoreProperties(ignoreUnknown = true) +public class ApplicationAttemptInfo extends BaseAttemptInfo { + protected long failureRestartCounter; + protected long schedulingFailureRestartCounter; + + public ApplicationAttemptInfo() { + super(); + failureRestartCounter = 0L; Review Comment: For the counter, `int` is enough already, isn't it? ``` int 32 -2,147,483,648 to 2,147,483,647 long 64 -9,223,372,036,854,775,808 to 9,223,372,036,854,775,807 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
