yaooqinn commented on PR #54565: URL: https://github.com/apache/spark/pull/54565#issuecomment-3999158121
Thanks @sarutak for the thorough review! All 4 points addressed: 1. **Toggle compact/detailed mode** ✅ — Added a "Show metrics in graph nodes" checkbox that switches between compact labels (name only) and detailed labels (name + all metrics in nodes). State persisted in localStorage. 2. **`desc` in side panel** ✅ — Added the full plan description (`desc`) to the side panel JSON and display. Now when clicking a `HashAggregate`, you see `HashAggregate(keys=[v#5], functions=[count(1)])` which disambiguates duplicates. 3. **`<`/`>` in operator names** ✅ — Verified: DOT labels use `StringEscapeUtils.escapeJava()` and dagre-d3 renders SVG `<text>` elements (not innerHTML), so special characters are safe. 4. **Edge connections for metric-less nodes** ✅ — Verified: dagre-d3 auto-sizes nodes based on label content. Compact labels just produce smaller nodes; edges connect to node borders correctly regardless of size. No gaps observed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
