sarutak commented on PR #54565: URL: https://github.com/apache/spark/pull/54565#issuecomment-3999054213
Thank you @yaooqinn for proposing a nice feature! I'd like to leave some comments and questions. * As @gengliangwang was concerned, I'm wondering some users may prefer the old view where all metrics are visible at a glance. So, how about adding a toggle to switch between compact and detailed (legacy) modes? * When there are multiple operators with the same name (e.g., multiple `HashAggregate`s), the panel header only shows the operator name, making it hard to tell which one is selected without looking at the graph highlight. Would it be worth adding the `desc` field to `makeNodeDetailsJson` and displaying it in the panel? * Since `labelType: "html"` was [removed ](https://github.com/apache/spark/pull/54565/changes#diff-9779b5dc950159bfff9446ddd33dc6b6b27cddd276a50eb516a22e0efa13ef97L197)and labels are now plain text, could you verify that operator names containing `<` or `>` render correctly in the SVG text nodes? * The old code added empty lines for nodes without metrics to ensure consistent node heights. With compact labels this seems unnecessary, but have you checked that edge-to-node connections still look correct (no gaps) for metric-less nodes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
