dongjoon-hyun commented on code in PR #54575:
URL: https://github.com/apache/spark/pull/54575#discussion_r2881579165
##########
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala:
##########
@@ -154,8 +196,15 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
memoryManager = new HistoryServerMemoryManager(conf)
}
- private val fileCompactor = new EventLogFileCompactor(conf, hadoopConf, fs,
- conf.get(EVENT_LOG_ROLLING_MAX_FILES_TO_RETAIN),
conf.get(EVENT_LOG_COMPACTION_SCORE_THRESHOLD))
+ private val fileCompactors: Map[String, EventLogFileCompactor] =
logDirFs.map {
+ case (dir, dirFs) =>
+ dir -> new EventLogFileCompactor(conf, hadoopConf, dirFs,
+ conf.get(EVENT_LOG_ROLLING_MAX_FILES_TO_RETAIN),
+ conf.get(EVENT_LOG_COMPACTION_SCORE_THRESHOLD))
+ }
+
+ // For backward compatibility
+ private val fileCompactor = fileCompactors(logDir)
Review Comment:
ditto. What happens when we remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
