dongjoon-hyun commented on code in PR #54575:
URL: https://github.com/apache/spark/pull/54575#discussion_r2881571723
##########
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala:
##########
@@ -106,7 +106,12 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
// Number of threads used to compact rolling event logs.
private val numCompactThreads = conf.get(History.NUM_COMPACT_THREADS)
- private val logDir = conf.get(History.HISTORY_LOG_DIR)
+ private val logDirs = conf.get(History.HISTORY_LOG_DIR)
+ .split(",").map(_.trim).filter(_.nonEmpty).toSeq
+ require(logDirs.nonEmpty, "spark.history.fs.logDirectory must specify at
least one directory.")
Review Comment:
Shall we validate this via `checkValue` in the config?
https://github.com/apache/spark/blob/e3dd094da891f7086b0da5d44c269d7a1d7930d2/core/src/main/scala/org/apache/spark/internal/config/History.scala#L29-L33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
