cloud-fan commented on code in PR #52334:
URL: https://github.com/apache/spark/pull/52334#discussion_r2416818249
##########
sql/core/src/main/scala/org/apache/spark/sql/classic/SparkSession.scala:
##########
@@ -448,16 +448,26 @@ class SparkSession private(
private[sql] def sql(sqlText: String, args: Array[_], tracker:
QueryPlanningTracker): DataFrame =
withActive {
val plan = tracker.measurePhase(QueryPlanningTracker.PARSING) {
- val parsedPlan = sessionState.sqlParser.parsePlan(sqlText)
- if (args.nonEmpty) {
- // Check for SQL scripting with positional parameters before
creating parameterized query
- if (parsedPlan.isInstanceOf[CompoundBody]) {
- throw
SqlScriptingErrors.positionalParametersAreNotSupportedWithSqlScripting()
+ val parsedPlan = if (args.nonEmpty) {
+ // Set parameter context for parsing
+ val paramContext =
PositionalParameterContext(args.map(lit(_).expr).toSeq)
+ ThreadLocalParameterContext.withContext(paramContext) {
+ val parsed = sessionState.sqlParser.parsePlan(sqlText)
Review Comment:
Techinically we can avoid using ThreadLocal:
- when creating the pre-parser, pass in the parameter context
- invoke the pre-parser explicitly here, and then invoke the actual parser.
We can't change the signature of the actual parser but the new pre-parser is
a different story.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
