srielau commented on code in PR #52334: URL: https://github.com/apache/spark/pull/52334#discussion_r2376034470
########## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ########## @@ -40,6 +40,12 @@ options { tokenVocab = SqlBaseLexer; } * When true, double quoted literals are identifiers rather than STRINGs. */ public boolean double_quoted_identifiers = false; + + /** + * When false, parameter markers (? and :param) are only allowed in constant contexts. + * When true, parameter markers are allowed everywhere a literal is supported. + */ + public boolean parameter_substitution_enabled = true; } Review Comment: Why would it need to? It covers the literals within. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org