zhengruifeng commented on code in PR #51831:
URL: https://github.com/apache/spark/pull/51831#discussion_r2373922319
##########
python/pyspark/sql/connect/functions/builtin.py:
##########
@@ -4027,25 +4028,210 @@ def make_timestamp_ntz(
mins: "ColumnOrName",
secs: "ColumnOrName",
) -> Column:
- return _invoke_function_over_columns(
- "make_timestamp_ntz", years, months, days, hours, mins, secs
+ ...
+
+
+@overload
+def make_timestamp_ntz(
+ *,
+ years: "ColumnOrName",
+ months: "ColumnOrName",
+ days: "ColumnOrName",
+ hours: "ColumnOrName",
+ mins: "ColumnOrName",
+ secs: "ColumnOrName",
+) -> Column:
+ ...
+
+
+@overload
+def make_timestamp_ntz(
+ *,
+ date: "ColumnOrName",
+ time: "ColumnOrName",
+) -> Column:
+ ...
+
+
+def make_timestamp_ntz( # type: ignore[misc]
+ *args: "ColumnOrName",
Review Comment:
If we keep `*args: "ColumnOrName"`, we need a helper function to preprocess
the arguments so that it can be reused in all the places.
`def _preprocess_make_timestampe_args(...) -> Tuple[ColumnOrName, ...,
ColumnOrName]` which returns a 8-tuple for the 8 arguments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
