Yicong-Huang commented on code in PR #51831:
URL: https://github.com/apache/spark/pull/51831#discussion_r2375895704
##########
python/pyspark/sql/connect/functions/builtin.py:
##########
@@ -4027,14 +4028,96 @@ def make_timestamp_ntz(
mins: "ColumnOrName",
secs: "ColumnOrName",
) -> Column:
- return _invoke_function_over_columns(
- "make_timestamp_ntz", years, months, days, hours, mins, secs
+ ...
+
+
+@overload
+def make_timestamp_ntz(
+ *,
+ date: "ColumnOrName",
+ time: "ColumnOrName",
+) -> Column:
+ ...
+
+
+def make_timestamp_ntz(
+ years: Optional["ColumnOrName"] = None,
+ months: Optional["ColumnOrName"] = None,
+ days: Optional["ColumnOrName"] = None,
+ hours: Optional["ColumnOrName"] = None,
+ mins: Optional["ColumnOrName"] = None,
+ secs: Optional["ColumnOrName"] = None,
+ *,
+ date: Optional["ColumnOrName"] = None,
+ time: Optional["ColumnOrName"] = None,
+) -> Column:
+ # 6 positional/keyword arguments: years, months, days, hours, mins, secs
+ if (
+ all(kw is not None for kw in [years, months, days, hours, mins, secs])
+ and date is None
+ and time is None
+ ):
+ from typing import cast
Review Comment:
removed redundant imports (cast, PySparkValueError).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
