miland-db commented on code in PR #52371:
URL: https://github.com/apache/spark/pull/52371#discussion_r2368521705
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecution.scala:
##########
@@ -169,7 +206,11 @@ class SqlScriptingExecution(
case Some(handler) =>
val handlerFrame = new SqlScriptingExecutionFrame(
handler.body,
- SqlScriptingFrameType.HANDLER,
+ if (handler.handlerType == ExceptionHandlerType.CONTINUE) {
+ SqlScriptingFrameType.CONTINUE_HANDLER
+ } else {
+ SqlScriptingFrameType.EXIT_HANDLER
+ },
Review Comment:
IMO this `ExceptionHandlerType.EXIT/CONTINUE` and
`SqlScriptingFrameType.EXIT_HANDLER/CONTINUE_HANDLER` is a bit confusing. We
should maybe find a way to reuse information about handler type in execution
frame. Let's discuss this offline first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
