miland-db commented on code in PR #52371:
URL: https://github.com/apache/spark/pull/52371#discussion_r2368530128
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingInterpreter.scala:
##########
@@ -88,7 +88,8 @@ case class SqlScriptingInterpreter(session: SparkSession) {
context)
// Execution node of handler.
- val handlerScopeLabel = if (handler.handlerType ==
ExceptionHandlerType.EXIT) {
+ val handlerScopeLabel = if (handler.handlerType ==
ExceptionHandlerType.EXIT
+ || handler.handlerType ==
ExceptionHandlerType.CONTINUE) {
Review Comment:
It's the label of the scope where exception handler is defined.
@TeodorDjelic as you go through code feel free to add even more comments
explaining what's going on.
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingInterpreter.scala:
##########
@@ -88,7 +88,8 @@ case class SqlScriptingInterpreter(session: SparkSession) {
context)
// Execution node of handler.
- val handlerScopeLabel = if (handler.handlerType ==
ExceptionHandlerType.EXIT) {
+ val handlerScopeLabel = if (handler.handlerType ==
ExceptionHandlerType.EXIT
+ || handler.handlerType ==
ExceptionHandlerType.CONTINUE) {
Review Comment:
This looks like a great place for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
