Pajaraja commented on code in PR #51847:
URL: https://github.com/apache/spark/pull/51847#discussion_r2318938498
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -1346,15 +1346,26 @@ class AstBuilder extends DataTypeAstBuilder
}
// LIMIT
- // - LIMIT ALL is the same as omitting the LIMIT clause
- withOffset.optional(limit) {
+ // LIMIT ALL creates LimitAll node which can be used for infinite
recursions in recursive CTEs.
+ if (ctx.ALL() != null) {
if (forPipeOperators && clause.nonEmpty && clause !=
PipeOperators.offsetClause) {
throw
QueryParsingErrors.multipleQueryResultClausesWithPipeOperatorsUnsupportedError(
ctx, clause, PipeOperators.limitClause)
}
clause = PipeOperators.limitClause
- Limit(typedVisit(limit), withOffset)
+ LimitAll(withOffset)
+ } else {
+ withOffset.optional(limit) {
+ if (forPipeOperators && clause.nonEmpty && clause !=
PipeOperators.offsetClause) {
Review Comment:
Changed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
