cloud-fan commented on code in PR #51847: URL: https://github.com/apache/spark/pull/51847#discussion_r2315622497
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InlineCTE.scala: ########## @@ -189,14 +189,30 @@ case class InlineCTE( case ref: CTERelationRef => val refInfo = cteMap(ref.cteId) + val cteBody = refInfo.cteDef.child match { Review Comment: We should clearly define the rule for propagating unlimited recursion from CTE ref to `UnionLoop`. What if the rCTE is referenced more than once and one have LIMIT ALL but others don't? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org