LuciferYang commented on code in PR #51961:
URL: https://github.com/apache/spark/pull/51961#discussion_r2265385352
##########
common/kvstore/src/test/java/org/apache/spark/util/kvstore/LevelDBSuite.java:
##########
@@ -220,19 +220,19 @@ public void testRemoveAll() throws Exception {
db.removeAllByIndexValues(
ArrayKeyIndexType.class,
KVIndex.NATURAL_INDEX_NAME,
- ImmutableSet.of(new int[] {0, 0, 0}, new int[] { 2, 2, 2 }));
+ Set.of(new int[] {0, 0, 0}, new int[] { 2, 2, 2 }));
assertEquals(7, db.count(ArrayKeyIndexType.class));
db.removeAllByIndexValues(
ArrayKeyIndexType.class,
"id",
- ImmutableSet.of(new String[] { "things" }));
+ Set.<String[]>of(new String[] { "things" }));
Review Comment:
This is simply to align the testing approach for `InMemoryStore`, due to the
issue mentioned in
https://github.com/apache/spark/pull/51961/files#r2265383429, which appears to
affect only `InMemoryStore`. For `RocksDBStore`, even if `Set.of(new String[] {
"things" }));` is used here, the `RocksDBSuite` test will still succeed. This
seems like something worth investigating further—for example, are there any
differences in the implementations of `InMemoryStore` and `RocksDBStore`?
It's getting late in my time zone today, so I'll look into why this
discrepancy exists at a later time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
