dongjoon-hyun commented on code in PR #51961:
URL: https://github.com/apache/spark/pull/51961#discussion_r2265371922
##########
common/kvstore/src/test/java/org/apache/spark/util/kvstore/InMemoryStoreSuite.java:
##########
@@ -147,25 +147,25 @@ public void testRemoveAll() throws Exception {
assertFalse(store.removeAllByIndexValues(
ArrayKeyIndexType.class,
KVIndex.NATURAL_INDEX_NAME,
- ImmutableSet.of(new int[] {10, 10, 10}, new int[] { 3, 3, 3 })));
+ Set.of(new int[] {10, 10, 10}, new int[] { 3, 3, 3 })));
assertEquals(9, store.count(ArrayKeyIndexType.class));
assertTrue(store.removeAllByIndexValues(
ArrayKeyIndexType.class,
KVIndex.NATURAL_INDEX_NAME,
- ImmutableSet.of(new int[] {0, 0, 0}, new int[] { 2, 2, 2 })));
+ Set.of(new int[] {0, 0, 0}, new int[] { 2, 2, 2 })));
assertEquals(7, store.count(ArrayKeyIndexType.class));
assertTrue(store.removeAllByIndexValues(
ArrayKeyIndexType.class,
"id",
- ImmutableSet.of(new String [] { "things" })));
+ Set.of(new String [] { "things" })));
Review Comment:
The code looks correct but it seems to fails. Could you double-check this,
@LuciferYang ?
```
$ build/sbt "kvstore/test"
....
[error] Test org.apache.spark.util.kvstore.InMemoryStoreSuite.testRemoveAll
failed: org.opentest4j.AssertionFailedError: expected: <true> but was: <false>,
took 0.004s
[error] at
org.apache.spark.util.kvstore.InMemoryStoreSuite.testRemoveAll(InMemoryStoreSuite.java:159)
[error] at java.lang.reflect.Method.invoke(Method.java:580)
[error] at java.util.ArrayList.forEach(ArrayList.java:1596)
[error] at java.util.ArrayList.forEach(ArrayList.java:1596)
[info] Test run finished: 1 failed, 0 ignored, 8 total, 0.009s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
