uros-db commented on code in PR #51547: URL: https://github.com/apache/spark/pull/51547#discussion_r2227916702
########## sql/core/src/test/resources/sql-tests/inputs/time.sql: ########## @@ -79,6 +81,70 @@ SELECT cast(cast('12:00' as time(0)) as time(2)); SELECT cast(('23:59:59.001001' :: time(6)) as time(4)); SELECT cast(time'11:59:59.999999' as time without time zone); +-- SPARK-51554: time truncation. Review Comment: There are already tests with different time precisions. However, I'm adding more. Also, adding tests with units in lowercase / mixed case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org