uros-db commented on code in PR #51547: URL: https://github.com/apache/spark/pull/51547#discussion_r2226688707
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala: ########## @@ -508,6 +508,43 @@ object DateTimeUtils extends SparkDateTimeUtils { } } + /** + * Returns time truncated to the unit specified by the level. + */ + private def parseTimeTruncLevel(level: UTF8String): ChronoUnit = { + if (level == null) { + throw QueryExecutionErrors.invalidTimeTruncUnitError("time_trunc", "null") + } Review Comment: Makes sense, I'll leave a `require` there just in case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org