cloud-fan commented on code in PR #51002: URL: https://github.com/apache/spark/pull/51002#discussion_r2110775098
########## sql/api/src/main/scala/org/apache/spark/sql/types/Metadata.scala: ########## @@ -120,6 +122,12 @@ sealed class Metadata private[types] (private[types] val map: Map[String, Any]) map(key).asInstanceOf[T] } + private[sql] def getExpression[E](key: String): (String, Option[E]) = { Review Comment: ah I see. Shall we make the functions general here? e.g. we add `def putAny` and `def getAny` in `class Metadata` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org