ilicmarkodb commented on code in PR #51001:
URL: https://github.com/apache/spark/pull/51001#discussion_r2107755331
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/CharVarcharDDLTestBase.scala:
##########
@@ -59,8 +59,7 @@ trait CharVarcharDDLTestBase extends QueryTest with
SQLTestUtils {
"newType" -> "\"CHAR(5)\"",
"newName" -> "`c`",
"originName" -> "`c`",
- "table" -> table),
- queryContext = Array(ExpectedContext(fragment = alterSQL, start = 0,
stop = 41))
+ "table" -> table)
Review Comment:
these changes are needed because plan is copied in
`resolveAlterColumnsDataType` and `origin` from `TreeNode` is lost. Not sure if
this is proper way do handle this. Is then origin lost in every Analyzer rule
which copies plan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
