dejankrak-db commented on code in PR #51001:
URL: https://github.com/apache/spark/pull/51001#discussion_r2106305165
##########
sql/core/src/test/scala/org/apache/spark/sql/collation/DefaultCollationTestSuite.scala:
##########
@@ -128,10 +128,23 @@ abstract class DefaultCollationTestSuite extends
QueryTest with SharedSparkSessi
sql(s"ALTER TABLE $testTable ALTER COLUMN c1 TYPE STRING COLLATE
UNICODE_CI")
assertTableColumnCollation(testTable, "c1", "UNICODE_CI")
+ // alter table alter column should inherit the table collation only if
the column was not
+ // originally of a string type
+ sql(s"ALTER TABLE $testTable ALTER COLUMN c1 TYPE STRING")
+ assertTableColumnCollation(testTable, "c1", "UTF8_BINARY")
Review Comment:
This is not right, based on the discussions I think we need to keep the
original c1 column collation, not change it to default UTF8_BINARY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
